Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update phpstan-baseline.neon.dist for PHPStan 1.8.7 #6627

Merged
merged 1 commit into from
Oct 5, 2022
Merged

chore: update phpstan-baseline.neon.dist for PHPStan 1.8.7 #6627

merged 1 commit into from
Oct 5, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 4, 2022 •
edited
Loading

Description
See https://github.com/codeigniter4/CodeIgniter4/actions/runs/3186033011

It seems the error message has been changed:

 ------ ----------------------------------------------------------------------------------------------------
  Line   system/CLI/Console.php
 ------ ----------------------------------------------------------------------------------------------------
  71     Strict comparison using === between array<mixed, mixed> and array{} will always evaluate to false.
 ------ ----------------------------------------------------------------------------------------------------

But the $params may be empty array, so it still seems false positive.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis
chore: update phpstan-baseline.neon.dist for PHPStan 1.8.7
a45a796 
It seems the error message has been changed:
 ------ ----------------------------------------------------------------------------------------------------
  Line   system/CLI/Console.php
 ------ ----------------------------------------------------------------------------------------------------
  71     Strict comparison using === between array<mixed, mixed> and array{} will always evaluate to false.
 ------ ----------------------------------------------------------------------------------------------------
But the $params may be empty array, so it still seems false positive.
@kenjis kenjis added the 4.3 label Oct 4, 2022
@kenjis kenjis merged commit c488587 into codeigniter4:4.3 Oct 5, 2022
@kenjis kenjis deleted the fix-phpstan-187-new-error branch October 5, 2022 02:50
@kenjis kenjis mentioned this pull request Oct 6, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @paulbalandan